Request for Review: libevent
Nils Philippsen
nphilipp at redhat.com
Fri Jun 17 15:17:31 UTC 2005
Hi Ralf,
On Fri, 2005-06-17 at 15:44 +0200, Ralf Ertzinger wrote:
> Sorry for the delay, this is the updated version of my libevent package,
> first presented for review 10 days ago. This version adds some
> %doc as suggsted and updates to the latest upstream version.
>
> http://www.skytale.net/files/libevent/libevent-1.1a-1.src.rpm
some comments:
> Release: 1%{?dist}
Is %dist defined always (forgive me if this is explained elsewhere,
googling %dist didn't yield suitable results)? If not (e.g. in the case
of devel/Rawhide) this could lead to the package in FE n being
"older" (RPM-wise) than the package in FE n-1, causing in it not being
updated. Cf. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=160808
> %build
> %configure \
> --disable-dependency-tracking
Really? Call me paranoid, but I'd rather leave that out.
> make %{?_smp_mflags}
>
>
> %install
> rm -rf $RPM_BUILD_ROOT
> make install DESTDIR=$RPM_BUILD_ROOT
%makeinstall worked fine for me
> rm -rf $RPM_BUILD_ROOT%{_libdir}/*.la
I don't know about that one -- has there been any consensus about
whether to include .la files?
Nils
--
Nils Philippsen / Red Hat / nphilipp at redhat.com
"They that can give up essential liberty to obtain a little temporary
safety deserve neither liberty nor safety." -- B. Franklin, 1759
PGP fingerprint: C4A8 9474 5C4C ADE3 2B8F 656D 47D8 9B65 6951 3011
More information about the fedora-extras-list
mailing list