[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: NetworkManager-vpnc



On Fri, 2005-06-17 at 12:18 -0400, David Zeuthen wrote:
> NetworkManager-vpnc is available at
> 
>  http://people.redhat.com/davidz/nm-vpnc2/
>  http://people.redhat.com/davidz/nm-vpnc2/NetworkManager-vpnc-0.1-1.cvs20050617.src.rpm

Some comments:
* Need to Prereq: /usr/bin/update-desktop-database if it's going to be
called unconditionally in %post
* Is there a real reason to ship the .la and .a files?  I'd nuke them.
* Should use %find_lang %{name} in %install and then include the locale
files via %files -f %{name}.lang

That's what jumps out at me from a quick look.

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]