Request for review: ctrlproxy

David Woodhouse dwmw2 at infradead.org
Sun Jun 19 16:10:04 UTC 2005


On Fri, 2005-06-17 at 15:04 -0500, Josh Boyer wrote:
> 1) The preferred BuildRoot tag is:
> 2) %{_datadir} can be used instead of /usr/share/
> 3) %{_bindir} can be used instead of /usr/bin

Done.

> 4) Does the package really want to own all of /usr/bin/*? 

It wants to own everything _it_ puts in /usr/bin, which is two files
now.

> 5) Same as 4, but with %{_includedir}/ctrlproxy.h instead
> of /usr/include/*

I dropped the include file.

> 6) The proceeding / before %{_libdir}/ctrlproxy/* is not needed

Removed.

Thanks.

-- 
dwmw2




More information about the fedora-extras-list mailing list