[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: rinetd



On Fri, 2005-06-03 at 02:54 -0400, Chris Ricker wrote:
> <http://www.oobleck.net/kaboom/fedora/srpms/rinetd-0.62-3.src.rpm>

A "FYI" comparison between this package and mine at
http://cachalot.mine.nu/4/SRPMS/rinetd-0.62-0.1.src.rpm :

- A proper "reload" action for the init script would be possible,
  rinetd responds to HUP as expected.  If implemented, the logrotate
  script should probably switch to using copytruncate or restart
  instead of reload.
- The Debian patch included in my package adds autotools support,
  as well as some other useful-looking tweaks.
- "A" could be removed from the package summary.
- Why are rinetd.conf modes 600, won't 644 do?

None of the above are really blockers IMO, so approved.  If there's a
good reason to keep the config file non-readable by normal users, it'd
be useful to add a comment about that in the specfile.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]