[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New Package: fish



On Mon, 20 Jun 2005 16:58:07 +0200, Axel Liljencrantz wrote:

> Aside from the above changes, I've also added
> 
> provides: fish xsel mimedb
> 
> to the spec file.

And these require an explanation, at least in the spec file.

For example, "Provides: %name = %version-%release" is automatic,
so your one would be redundant and less accurate (= non-versioned).

[...]

Btw, caution! Adding things during a review often asks for trouble as your
current reviewer may not agree with changes he didn't propose.

> The new version is available here:
> 
> http://roo.no-ip.org/fish/fedora/fish-1.11.1-2.src.rpm

In addition to the comments done by earlier reviewers, quite some
clean-up is needed:

 * No Packager or Vendor tags in a spec file, please. These belong
   into your local build environment only.

 * "License: GPL"? No. The C source files disagree. => LGPL

 * Use %configure instead of "./configure --prefix=...". rpmlint even
   warns about that. The %configure macro sets prefix, libdir and
   friends for you.

 * %install section is missing "rm -rf $RPM_BUILD_ROOT" at the
   beginning.

 * Your %postun script will break upgrades, as it will be executed
   last. Look like e.g. "bash" does it.

 * Manual pages are installed into %_mandir and are flagged %doc
   automatically. Use %_mandir not /usr/man

 * Use the other macros like %_datadir (/usr/share), %_bindir (/usr/bin)
   %_sysconfdir (/etc)

 * Package doesn't build with $RPM_OPT_FLAGS, because it overrides CFLAGS
   with its own flags.

 * Package fails to build. Missing at least "Buildrequires: ncurses-devel"

 * (RFE: Is it possible to install documentation files into %_docdir like
   most other packages? i.e. %_datadir/doc/%name-%version)

 * Package fails to install:

Preparing...                ########################################### [100%]
   1:fish                   ########################################### [100%]
/home/qa/tmp/rpm/tmp/rpm-tmp.28773: line 11: syntax error: unexpected end of file
error: %post(fish-1.11.1-2.i386) scriptlet failed, exit status 2

-- 
Fedora Core release 4 (Stentz) - Linux 2.6.11-1.1369_FC4
loadavg: 1.75 1.18 1.06


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]