Request for Review: perl-Tk-JPEG-Lite

[Michael Schwendt]

On Sat, 25 Jun 2005 00:44:14 +0200, Andreas Bierfert wrote:

> >>INSTALLARCHLIB=$RPM_BUILD_ROOT%{perl_archlib}
> > 
> > 
> > Is this used actually? That would be outside vendor Perl locations.
> 
> changed
> 
> > No other things reviewed, as I don't have Perl::Tk yet.
> 
> FC4 is out isn't it? FC3 is waiting for buildsys stuff to change and devel is
> devel... ;)

Hah! When I replied I was in FC4 as could be seen in my sig. I still
did not have perl-Tk installed. ;)
 
> http://fedora.lowlatency.de/review/perl-Tk-JPEG-Lite-2.01403-2.src.rpm
> http://fedora.lowlatency.de/review/perl-Tk-JPEG-Lite.spec

Fails to build. Missing buildrequires xorg-x11-devel.

Fully correct directory ownership would be:
--- perl-Tk-JPEG-Lite.spec~     2005-06-25 00:37:58.000000000 +0200
+++ perl-Tk-JPEG-Lite.spec      2005-06-25 14:25:20.000000000 +0200
@@ -46,7 +46,8 @@
 %defattr(-,root,root,-)
 %doc README
 %{_bindir}/*
-%{perl_vendorarch}/*
+%{perl_vendorarch}/Tk/*
+%{perl_vendorarch}/auto/Tk/*
 %{_mandir}/man*/*
 
 %changelog


Install-test:
    file /usr/bin/tkjpeg from install of perl-Tk-JPEG-Lite-2.01403-2 conflicts with file from package perl-Tk-804.027-6.fc4
    file /usr/share/man/man1/tkjpeg.1.gz from install of perl-Tk-JPEG-Lite-2.01403-2 conflicts with file from package perl-Tk-804.027-6.fc4


Ooops? It's included there already?

$ rpm -ql perl-Tk | grep -i jpeg
/usr/bin/tkjpeg
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/Tk/JPEG.pm
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/auto/Tk/JPEG
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/auto/Tk/JPEG/JPEG.so
/usr/share/man/man1/tkjpeg.1.gz
/usr/share/man/man3/Tk::JPEG.3pm.gz

-- 
Michael Schwendt <mschwendt at users.sf.net>
Fedora Core release 4 (Stentz) - Linux 2.6.11-1.1369_FC4
loadavg: 2.10 1.72 1.39