[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New package: perl-MP3-Tag



On Sat, 25 Jun 2005 10:35:07 -0700, Chip Turner wrote:

> No love?

The CVS accounts system lists over hundred contributors, so surely reviews
should not be done by always the same few people. Additionally, some of
them have been at FUDCon 2, which has had its second day today, or are
still on the way home from Karlsruhe.

> http://perl.pattern.net/perl-MP3-Tag-0.94-1.src.rpm

Those cpanflute2 auto-generated spec files are awful.

Now generally, I don't care that much about how a spec file looks if it
creates a working package, with no issues in the binary rpm. But the
package should install the files into Perl vendor locations, not site
locations. [With Fedora perl spec template from the fedora-rpmdevtools
package, which has been enhanced since its creation at fedora.us,
packaging many Perl modules gets really easy.]

To have $RPM_BUILD_ROOT somewhere in %build is a mistake in 99.9%
of the cases. Hardly any build process needs to know about paths
into a buildroot. It only increases the possibility that buildroot
paths end up in compiled code or files generated from templates.

The package also lacks the versioned :MODULE_COMPAT dependency, which is
your invention, IIRC. Particularly useful if you want to make sure a newer
Perl version still has the used vendor locations in its module search
path.

"make test" should go into the %check section.

ID3v2 support accesses Compress::Zlib, but no dependency on
perl-Compress-Zlib is seen.

Feel free to import into CVS and give the package some love there.

-- 
Michael Schwendt <mschwendt users sf net>
Fedora Core release 4 (Stentz) - Linux 2.6.11-1.1369_FC4
loadavg: 1.15 1.07 1.01


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]