[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New package: perl-MP3-Tag



On Sun, 2005-06-26 at 10:24 +1000, Michael Fleming wrote:
> On Sat, 2005-06-25 at 16:36 -0700, Chip Turner wrote:
> > On 6/25/05, Michael Schwendt <bugs michael gmx net> wrote:
> > > On Sat, 25 Jun 2005 10:35:07 -0700, Chip Turner wrote:
> > > 
> > > > No love?
> 
> I'm building it now in mock, I'll give it a once-over when built and
> post some findings to the list. I have a very vague recollection of
> packaging this myself in the distant past for local usage, and there
> wasn't that much to it :-)

OK, this builds fine in mock (not that I thought any differently mind
you)

The only issues I found were the hardcoded Packager entry (we don't want
this) and the use of perl's site_lib (this will be fine if you've
already changed it to vendor_lib in a subsequent spec revision)

A more verbose %description would be nice, but not a showstopper (the
package name essentially speaks for itself, but it's still good
practice)

Gets the thumbs up from me otherwise.

Michael.

-- 
Michael Fleming <mfleming enlartenment com>
WWW: http://www.enlartenment.com/
APT/YUM Repository for Fedora Core:
http://www.enlartenment.com/packages.php
"Bother" said the Borg, "We've assimilated Pooh!"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]