[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: request for review: dirvish and required perl modules



On Mon, 2005-06-27 at 13:34 -0400, Chris Ricker wrote:

> <http://www.oobleck.net/kaboom/fedora/srpms/perl-Time-modules-0.2003.1126-1.src.rpm>

Approved with the attached patch applied:
- License is not Public Domain, except for some bits of Time::Timezone;
  Distributable is AFAICS the best we can state here.
- Cosmetic: stuff not needed for noarch packages pruned, README added.

Feel free to commit and I'll recheck and follow up with the approval
message.
--- perl-Time-modules.spec~	2005-05-27 20:13:43.000000000 +0300
+++ perl-Time-modules.spec	2005-06-27 21:55:05.000000000 +0300
@@ -3,7 +3,7 @@
 Release: 1
 Summary: Perl modules for parsing dates and times       
 Group: Development/Libraries
-License: Public Domain       
+License: Distributable
 URL: http://search.cpan.org/dist/Time-modules/
 Source0: http://www.cpan.org/authors/id/M/MU/MUIR/modules/Time-modules-2003.1126.tar.gz
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
@@ -20,14 +20,13 @@
 %setup -q -n Time-modules-2003.1126
 
 %build
-CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor
-make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"
+%{__perl} Makefile.PL INSTALLDIRS=vendor
+make %{?_smp_mflags}
 
 %install
 rm -rf $RPM_BUILD_ROOT
 make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
 find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
 chmod -R u+w $RPM_BUILD_ROOT/*
 
@@ -39,7 +38,7 @@
 
 %files
 %defattr(-,root,root,-)
-%doc CHANGELOG
+%doc CHANGELOG README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*.3*
 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]