New Package: fish

[Oliver Falk]

On 06/28/2005 09:12 AM, Oliver Falk wrote:
> On 06/27/2005 10:09 PM, Axel Liljencrantz wrote:
> 
>> Thanks for the comments. I'm sorry for not answering your message any
>> sooner, but I've been unwell.
[ ... ]
> Just a note: I had no look at the new package (rel 5) yet, I just 
> answered the mail...

Some more comments:

* Source-Tags should contain the full URI to the tarball(s).
   So in your case:
   Source0: 
http://roo.no-ip.org/%{name}/files/%{version}/%{name}-%{version}.tar.bz2

* The make all is better written as: make %{?_smp_mflags} all

* The rm after %install is more secure, if you write:

   [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT

   Same for the %clean section, of course.

* I would remove the docs after install with:
   rm -rf $RPM_BUILD_ROOT%{_datadir}/doc

   and add (also add the ChangeLog) them via

   %doc user_doc/* ChangeLog

   Because, directly installing to %{_datadir}/doc seems not very fine -
   for me...

* And the spec is really missing a %changelog section! :-)
   [oliver at moon SPECS]$ rpmlint ../SRPMS/fish-1.11.1-5.src.rpm
   E: fish no-changelogname-tag

* Upgrades (-U) still lists /usr/bin/fish in /etc/shells twice. :-/
   I guess a install (-i) with --force will also do this.

A question: is the xsel command really needed? For example, most of my 
machines (webservers, database, ...) don't have X installed and therefor 
have no X libraries installed. And to install all those libs just for a 
shell seems to be an overhead...

* OK:
   - Install works fine (-i)
   - Uninstall works fine (-e)

* Take a look at your webpage (http://roo.no-ip.org/fish/) and search 
for 1386. ;-)

Best,
  Oliver