[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New Package: fish



On 06/28/2005 11:39 AM, Michael Schwendt wrote:
On Tue, 28 Jun 2005 10:43:52 +0200, Oliver Falk wrote:


* The rm after %install is more secure, if you write:

  [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT

Same for the %clean section, of course.


No, please don't recommend that. Besides decreasing readability, if some
user really tried to override the buildroot which is specified at the
top of the spec file and define it as '/', it would disable several of
rpmbuild's scripts. Additionally, there are other paths which somebody,
who doesn't know what he's doing, could specify with which to mess up a
system: /opt, /usr, //, /root, ~, to name a few.

Yes, there are other stupid paths that could be set, but "/" is the absolute stupiest. :-)


However, if it's not used in other packages, then I'll not recommend it again.

Best,
 Oliver


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]