New package: istanbul
Mark McLoughlin
markmc at redhat.com
Wed Jun 29 14:54:18 UTC 2005
Hey,
Quick comments:
- See sabayon.spec for some foo to require a specific python ABI
version and figure out the path for site-packages:
http://cvs.fedora.redhat.com/viewcvs/*checkout*/devel/sabayon/sabayon.spec?root=extras
I think its in the packaging guidelines.
- You should own the site-packages/istanbul/ dir
- Instead of re-autogen-ing for the patch, you could consider
including a diff of the autogened files. It could turn out to be
pretty ugly, but sometimes I've found it to work out better than
doing it at buildtime.
- Otherwise you need to BuildRequire: autoconf automake
- I doubt the BuildRequires: libtool is correct
- update-desktop-database isn't needed unless you've got MimeType=foo
AFAIR
- should desktop-file-install the .desktop file and BuildRequire:
desktop-file-utils
- Do you need to call ldconfig ?
Cheers,
Mark.
More information about the fedora-extras-list
mailing list