Request for review: GNU barcode

[Adrian Reber]

On Wed, Jun 29, 2005 at 11:15:13PM +0200, Andreas Thienemann wrote:
> SPEC: http://home.bawue.de/~ixs/barcode/barcode.spec
> SRPM: http://home.bawue.de/~ixs/barcode/barcode-0.98-1.src.rpm

The preferred value for the BuildRoot tag is:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

The Summary shouldn't include the package name.

%post and %preun scripts for the info file should be added.

builds in mock

md5sum matches upstream: 
7f10c3307b84a19a4ab2fa4b3f2974da barcode-0.98.tar.gz

There is a problem during installation:
file /usr/share/man/man1/barcode.1.gz from install of barcode-0.98-1.fc4
conflicts with file from package xscreensaver-extras-4.21-4

> I need a bit of advice on the -devel package.
> barcode installs a .h and a .a file. Would it be sensible to package them 
> into a -devel package or is it simply not worth it and they should be put 
> into the main package?
> Personally, I prefer the -devel package, but for two files it might simply 
> be overkill.
> Opinions?

Definitely make -devel subpackage.

		Adrian

-- 
Adrian Reber <adrian at lisas.de>            http://lisas.de/~adrian/
   "Summer is butter on your chin and corn mush between every tooth." -Calvin