[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: rinetd



On Thu, 2005-06-30 at 14:03 -0400, Chris Ricker wrote:
> On Sun, 19 Jun 2005, Ville Skytta  wrote:
> 
> > A "FYI" comparison between this package and mine at
> > http://cachalot.mine.nu/4/SRPMS/rinetd-0.62-0.1.src.rpm :
> > 
> > - A proper "reload" action for the init script would be possible,
> >   rinetd responds to HUP as expected.  If implemented, the logrotate
> >   script should probably switch to using copytruncate or restart
> >   instead of reload.
> 
> Changed - reload does a HUP if it's running, and logrotate does a restart

Minor issue, and FWIW, as we do not have any hard LSB compliancy
requirements:  According to how I read LSB, reload should not restart
the service, ie. not bring it up if it's not running.  And force_reload
should only reload (or restart) if the service is running (I missed this
in my package too).
http://refspecs.freestandards.org/LSB_2.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html

> > - The Debian patch included in my package adds autotools support,
> >   as well as some other useful-looking tweaks.
> 
> That I didn't want to include outright as it changes a lot.
> 
> Some of the changes (like fprintf -> syslog, for example) look 
> useful, so I may patch in bits of it later

Ok.

> > None of the above are really blockers IMO, so approved.  If there's a
> > good reason to keep the config file non-readable by normal users, it'd
> > be useful to add a comment about that in the specfile.
> 
> Thanks, I'll import and build in a sec

The above still applies, so I'll post the approval message now.  Thanks.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]