Review: ufraw

[Brian Pepple]

On Thu, 2005-03-24 at 14:17 +0100, Nils Philippsen wrote:
> I've just imported ufraw into CVS and it'd be great if someone could
> review it.

PUBLISH +1

MD5Sums:
24eb4c18ea8927e2b0516f0003ac748a  ufraw-0.4-1.src.rpm
c66a2498b3fb74eef6f3b7ce5477d44a  ufraw-0.4.tar.gz
79852c137f73cd2bd7681bb1f6f57fa9  ufraw.spec
94d55d512a9ba36caa9b7df079bae19f  COPYING

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* No deprecated fields used
* All necessary BuildRequires listed.
* All desired features are enabled
* Package rebuilds as non-root user
* Package installs and uninstalls cleanly on FC-3.

Minor:
* Unable to test plugin, since my camera doesn't take raw images.
* Rpmlint errors: Strange file permissions error.
  https://www.redhat.com/archives/fedora-extras-list/2005-
March/msg00952.html

/B
-- 
Brian Pepple <bdpepple at ameritech.net>

gpg --keyserver pgp.mit.edu --recv-keys 810CC15E
BD5E 6F9E 8688 E668 8F5B  CBDE 326A E936 810C C15E
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050325/9c213093/attachment.sig>