Review needed: bzflag

[Nils Philippsen]

On Fri, 2005-03-04 at 20:04 +0100, Adrian Reber wrote:
> On Fri, Mar 04, 2005 at 05:00:34PM +0100, Nils Philippsen wrote:
> > I just imported bzflag to CVS and it would be great if someone could
> > review it.
> 
> Looks pretty good, but:
> 
> If you do not include curl-devel in the BuildRequires for a special
> reason it would be good to disable curl usage in the configure script or
> just add it as a BR.

done

> I personally like the BuildRoot from the PackagingGuidlines better:
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

done

> Package builds, installs and works.

Does this mean it's approved?

Thanks,
Nils
-- 
     Nils Philippsen    /    Red Hat    /    nphilipp at redhat.com
"They that can give up essential liberty to obtain a little temporary
 safety deserve neither liberty nor safety."     -- B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011