Self-Introduction: Christian Jodar (Tian)

[Ignacio Vazquez-Abrams]

On Tue, 2005-05-03 at 22:09 +0200, Tian wrote:
> http://download.gna.org/gcfilms/fedora/3/gcfilms-5.0-1.src.rpm


> Summary:        GCfilms, movies collection management

Summary should not contain %name in any form.

> Source0:        gcfilms-%{version}-bin.tar.gz

RPMs should be built from pristine source. As such, unless there's a
super-extra-special reason, this should be
http://download.gna.org/gcfilms/gcfilms-5.0.tar.gz.

> %if %{!?_without_freedesktop:1}0

Fedora packages should always be built to FreeDesktop specs, so you can
assume that this conditional will always be 1 and therefore you can drop
it.

> %post

> %postun

Good, you got the scriptlets right. Now you just have to add desktop-
file-utils and shared-mime-info to Requires(post) and Requires(postun).


> %dir %{_datadir}/gcfilms/doc
> %doc %{_datadir}/gcfilms/doc/README
> %doc %{_datadir}/gcfilms/doc/CHANGELOG

This sort of stuff should be in %{_defaultdocdir}/%{name}-%{version}.

> %dir %{_libdir}/gcfilms/

Since you appear to include every file under here without any %doc, %
config, or %ghost directives, you can just include %{_libdir}/gcfilms
instead and pick them all up in one fell swoop.

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050509/ac2a1404/attachment.sig>