New package: rblcheck

[Paul Howarth]

Oliver Falk wrote:
>>> Should be added:
>>> -s xbl.spamhaus.org
> 
> 
> OK. Added.

Unfortunately the comment in the changelog says you added 
xml.spamhaus.org rather than xbl.spamhaus.org (actual rblcheckrc is OK).

Running the standard test lookup of 127.0.0.2, I got:

$ rbl 127.0.0.2
127.0.0.2 listed by sbl.spamhaus.org: 
http://www.spamhaus.org/SBL/sbl.lasso?query=SBL233
127.0.0.2 listed by xbl.spamhaus.org: 
http://www.spamhaus.org/query/bl?ip=127.0.0.2
127.0.0.2 listed by dnsbl.njabl.org: open relay -- 1008601823
127.0.0.2 listed by unconfirmed.dsbl.org: http://dsbl.org/listing?127.0.0.2
127.0.0.2 listed by multihop.dsbl.org: http://dsbl.org/listing?127.0.0.2
127.0.0.2 listed by list.dsbl.org: http://dsbl.org/listing?127.0.0.2
127.0.0.2 listed by opm.blitzed.org: Open proxy - see 
http://opm.blitzed.org/127.0.0.2
127.0.0.2 listed by relays.ordb.org: Listed by ORDB - for testing 
purposes only
127.0.0.2 listed by dul.dnsbl.sorbs.net: Dynamic IP Addresses See: 
http://www.sorbs.net/lookup.shtml?127.0.0.2
127.0.0.2 listed by spam.dnsbl.sorbs.net: Spam Received See: 
http://www.dnsbl.sorbs.net/lookup.shtml?127.0.0.2
127.0.0.2 listed by cbl.abuseat.org: Blocked - see 
http://cbl.abuseat.org/lookup.cgi?ip=127.0.0.2

- OK

127.0.0.2 not listed by relay.ordb.org

- relay.ordb.org is a typo for relays.ordb.org (already included)

127.0.0.2 not listed by blackhole.compu.net

- blackhole.compu.net is a non-existent domain

127.0.0.2 not listed by blackholes.brainerd.net

- no standard test entry but http://blackholes.brainerd.net/ appears to 
be alive

127.0.0.2 listed by blackholes.five-ten-sg.com
127.0.0.2 listed by blackholes.intersil.net: .spam test entry - direct 
spam source

- OK

127.0.0.2 not listed by blackholes.wirehub.net

- blackholes.wirehub.net is a non-existent domain

127.0.0.2 listed by block.blars.org

- OK

127.0.0.2 not listed by bl.reynolds.net.au

- please see http://bl.reynolds.net.au/
- you probably want to replace this with lists from 
http://dnsbl.net.au/types/

127.0.0.2 listed by bl.spamcop.net: Blocked - see 
http://www.spamcop.net/bl.shtml?127.0.0.2

- OK

127.0.0.2 not listed by dynablock.wirehub.net

- dynablock.wirehub.net is a non-existent domain

127.0.0.2 listed by flowgoaway.com: Keep away from sunlight, pets and 
small children.

- OK

127.0.0.2 not listed by http.opm.blitzed.org

- http.opm.blitzed.org is a non-existent domain

127.0.0.2 listed by korea.services.net: Blocked due to spam, see 
http://korea.services.net/blocked.phtml?addr=127.0.0.2

- OK

127.0.0.2 not listed by pm0-no-more.compu.net

- pm0-no-more.compu.net is a non-existent domain

127.0.0.2 not listed by relays.visi.com

- relays.visi.com is a non-existent domain

127.0.0.2 not listed by socks.opm.blitzed.org

- socks.opm.blitzed.org is a non-existent domain

127.0.0.2 listed by spamguard.leadmon.net: Dial-Up/Cable/DSL IP Range - 
Use your providers SMTP Gateway
127.0.0.2 listed by spamsources.fabel.dk: Blocked. Contact 
spam at netcetera.dk Include this in the subject: 127.0.0.2
127.0.0.2 listed by work.drbl.croco.net
127.0.0.2 listed by relays.linux-kernel.at: Listed_at:dsbl,lkernAT,abuseat

- OK

>>>And for the folks who had a look at the package 
>>>allready/will have a look at
>>>the package to approve it. Please note, that I just updated it at:
> 
> http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/rblcheck
> 
> And once again updated. Release 6.

You might want to add a DistTag to the release id - see:
http://fedoraproject.org/wiki/DistTag

BuildRoot: isn't the standard one advocated in the packaging guidelines
(http://fedoraproject.org/wiki/PackagingGuidelines):
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Package builds OK as non-root user.

rpmlint errors:

rpmlint -iv rblcheck-1.5-6*
I: rblcheck checking
E: rblcheck description-line-too-long operated by the MAPS 
(http://www.mail-abuse.org/) and ORBL (http://www.orbl.org/)
Your description lines must no exceed 80 characters. If a line is 
exceeding this number,
cut it to fit in two lines.

E: rblcheck non-standard-dir-perm 
/usr/share/doc/rblcheck-1.5/html/rblcheck 02755
A standard directory should have permission set to 0755. If you get this 
message,
that means that you have a wrong directory permission in your package.

E: rblcheck non-standard-dir-perm /usr/share/doc/rblcheck-1.5/html 02755
A standard directory should have permission set to 0755. If you get this 
message,
that means that you have a wrong directory permission in your package.

E: rblcheck non-standard-dir-perm 
/usr/share/doc/rblcheck-1.5/html/rblcheck/stylesheet-images 02755
A standard directory should have permission set to 0755. If you get this 
message,
that means that you have a wrong directory permission in your package.



The directory permission errors are probably due to my user account 
being in a SGID directory, and the installer copying the directory 
permissions. You can fix this by adding:

%{_bindir}/find . -type d -exec chmod 755 {} \;

after:

%setup -q

Paul.