[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

arc & gcc4 -> please review build fix


Anyone with more curent C knowledge than me care to review the arc gcc4 fix in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=156225 ?

Basically pristine source build fails with :

marc.c:309: error: incompatible implicit declaration of
function 'makefnam'
marc.c:51: error: previous implicit declaration of
'makefnam' was here

and we fix the build with :

diff -uNr arc-5.21j.orig/marc.c arc-5.21j/marc.c
--- arc-5.21j.orig/marc.c	2003-10-31 03:22:36.000000000 +0100
+++ arc-5.21j/marc.c	2005-05-21 10:40:22.000000000 +0200
@@ -48,7 +48,6 @@
 int nargs;			       /* number of arguments */
 char *arg[];			       /* pointers to arguments */
-    char *makefnam();		       /* filename fixup routine */
     char *envfind();
 #if	!_MTS
     char *arctemp2, *mktemp();		/* temp file stuff */

(build fix only - runtime not tested)

Since arc was originally imported in fedora.us for amavisd-new, and amavis can use nomarch instead, we can just dump arc and only keep nomarch. nomarch is already in extras and builds as-is with gcc4.

Anyway if the fix is right we can keep arc a little longer - someone may care about it.


Nicolas Mailhot

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]