Request for review: Enlightenment DR17 + EFL

[John Ellson]

Didier Casse wrote:

>On 5/30/05, John Ellson <ellson at research.att.com> wrote:
>  
>
>>Didier Casse wrote:
>>
>>    
>>
>>>Hi all,
>>>    I would like to have a review on the  Enlightenment DR17 package
>>>+ the accompanying Enlightenment Foundation Library packages (EFL).
>>>
>>>
>>>      
>>>
>>Entrance fails to find -lX11 on x86_64.    Should be -L/usr/X11R6/lib64
>>I think the problem is that @X_LIBS@  is not being used from
>>AC_PATH_XTRA in configure.in
>>
>>/usr/bin/gcc  -g -O2 -Wall   -o entranced  auth.o ipc.o md5.o spawner.o
>>util.o -L/usr/X11R6/lib -lX11 -lXext -lXau -L/usr/lib64 -lecore
>>-lecore_job -lecore_x -lecore_evas -lecore_con -lecore_ipc -lecore_txt
>>-lecore_fb -lecore_config -lecore_file -L/usr/lib64 -leet -lz -ljpeg -lm
>>-L/usr/lib64 -ledb -lz -lpam -lcrypt
>>/usr/bin/ld: cannot find -lX11
>>    
>>
>
>--x-libraries={_prefix}/X11R6/{_lib} should be able to fix this. ;-)
>
>  
>
No, that didn't work.

I think the following two changes are needed:


--- configure.in.old    2005-05-07 02:01:12.000000000 -0400
+++ configure.in        2005-05-30 09:25:36.000000000 -0400
@@ -199,10 +199,7 @@
 AC_DEFINE_UNQUOTED(ENTRANCE_XSESSION, "$xsession", [Xsession script])
 AC_SUBST(xsession)

-x_cflags="-I/usr/X11R6/include"
-x_libs="-L/usr/X11R6/lib -lX11 -lXext"
-AC_SUBST(x_cflags)
-AC_SUBST(x_libs)
+AC_PATH_XTRA

 EDJE_DEF=""
 AC_SUBST(EDJE_DEF)


--- src/daemon/Makefile.am.old  2005-05-30 09:26:39.000000000 -0400
+++ src/daemon/Makefile.am      2005-05-30 09:20:37.000000000 -0400
@@ -1,6 +1,6 @@
 ## Process this file with automake to produce Makefile.in

-INCLUDES = @x_cflags@ @ecore_cflags@ @edb_cflags@
+INCLUDES = @X_CFLAGS@ @ecore_cflags@ @edb_cflags@

 sbin_PROGRAMS = entranced
 bin_SCRIPTS = entrance_wrapper
@@ -8,4 +8,4 @@
 entranced_SOURCES = \
        auth.c auth.h Entranced.h ipc.c ipc.h md5.c md5.h spawner.c 
util.c util.h

-entranced_LDADD = @x_libs@ -lXau @ecore_libs@ @edb_libs@
+entranced_LDADD = @X_LIBS@ -lX11 -lXext -lXau @ecore_libs@ @edb_libs@