[Bug 169744] Review Request: libmthca - Mellanox hardware support for libibverbs
bugzilla at redhat.com
bugzilla at redhat.com
Thu Nov 3 21:02:54 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libmthca - Mellanox hardware support for libibverbs
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169744
------- Additional Comments From ed at eh3.com 2005-11-03 16:02 EST -------
Hi Roland, heres a quick review:
perhaps these two need work or perhaps [more likely? ;-)] I just don't
understand:
- The devel package includes a static library but there are no header
files -- I assume thats because this is a "plug-in library" for
libibverbs and it uses the libibverbs-devel headers so it doesn't
actually have to provide any headers itself, right? If so, thats
fine but then you should probably have libmthca-devel Require:
the libibverbs-devel package
- a shared library is installed but the usual post/postun ldconfig
scripts are not run -- is that really OK?
good:
+ source matches upstream using:
http://www.digitalvampire.org/fedora/libmthca-1.0-0.2.rc4.src.rpm
+ spec is simple, clean, and readable
+ license is OK and correctly included
+ builds in mock on FC4
+ *.la files correctly removed
+ no errors or warnings from rpmlint
And if someone donates a few compatible IB host adapters and an IB switch,
I'll gladly test this package on a few cluster nodes running Fedora. ;-)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list