[Bug 171801] Review Request: libspectrum, lib765 and libdsk - libraries required for the fuse-emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libspectrum, lib765 and libdsk - libraries required for the fuse-emulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171801





------- Additional Comments From paul at city-fan.org  2005-11-11 10:15 EST -------
Review (lib765 package ONLY):

- rpmlint nearly clean (see below)
- package naming OK
- package meets guidelines
- license is LGPL, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock for FC4 (i386)
- BR's OK
- no locales or pkgconfigs to worry about
- %post and %postun correctly call /sbin/ldconfig
- not relocatable
- no directory ownership or permissions issues
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- header and .so file properly delegated to -devel subpackage
- -devel package has proper base package dependency
- libtool archive properly excluded
- no desktop entry needed
- scriptlets are OK

Needswork:

* spec file should be called lib765.spec, not lib765-0.3.3-1.spec
* Vendor: and Packager: tags should be removed
* remove buildroot in %install rather than %prep
* add libdsk-devel dep for -devel subpackage; this is because the library
  provides additional functionality if libdsk-devel is installed, and so
  libdsk-devel should be added as a dep to maintain consistency of build
  results

Suggestions:

* use Fedora Extras standard buildroot
* unpack tarball quietly
* use DESTDIR with make instead of %makeinstall
* don't build or include the static library

Notes:

* rpmlint output:

  W: lib765-devel no-provides lib-devel

  This is due to rpmlint's assumption that "765" is a library version number
  rather than just a name, and can be ignored.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.