[Bug 172042] Review Request: cfitsio -- library to read and write FITS files.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cfitsio -- library to read and write FITS files.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172042


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From ed at eh3.com  2005-11-12 15:31 EST -------
Hi Matthew, looking at the 3.004-0.6.b SRPM it seems that there were 
still a few minor nits, some of which I missed earlier.  They are all 
fixed in the above patch to the specfile and described here:

nits:
 - please delete the "/%{_includedir}/%{name}/*.h" since it
     results in the header files being listed twice (the
     previous "/%{_includedir}/%{name}" already includes all
     of them)
 - rpmlint reports:
       W: cfitsio no-soname /usr/lib/libcfitsio.so
     and the attached (above) spec is one way to fix it.  For
     more info on shared libs, please see:
       http://www.tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html
 - please add "unset FC" to the end of the %build section
 - the macro usage can be simplified a bit and some of the
     "/"'s in some paths are redundant

good:
 + builds in mock on FC4
 + with the above patch, the only rpmlint complaint is:
       W: cfitsio-devel no-documentation
     which can be safely ignored

APPROVED.

Please feel free to make the above changes (or equivalent changes) after
you have checked it into CVS but before the first build request.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.