[Bug 173040] Review Request: rlog - Runtime Logging for C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rlog - Runtime Logging for C++


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173040





------- Additional Comments From lemenkov at newmail.ru  2005-11-13 16:42 EST -------
(In reply to comment #5)

> To make builds reproducible, you should either add the BuildRequires:
> or use '--disable-valgrind'. Because it does not seem to introduce
> additional dependencies, I do not see reasons to disable it.

OK, added valgrind to BuildRequires

> 'rpm -qf /usr/lib/pkgconfig' shows that this directories is owned by
> several core packages. Because yum's depsolver is not very smart, it
> will probably choose the wrong one which will perhaps add lots of
> unwanted dependencies

Done.
Requires: pkgconfig


> - you should add some more BuildRequires then (e.g. tetex-latex,
>   doxygen).

Done.

> - temporary pdf files (classrlog_*.pdf) should not be shipped but
>   'refman.pdf' only

Done.

> New issue
> 
> * 'INSTALL' should not be packaged; it does not contain anything which
>   might be useful for the enduser

Fixed.

Spec Name or Url: http://paula.comtv.ru/rlog.spec
SRPM Name or Url: http://paula.comtv.ru/rlog-1.3.7-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.