[Bug 170131] Review Request: php-extras - Additional PHP modules from the standard PHP distribution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-extras - Additional PHP modules from the standard PHP distribution


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170131





------- Additional Comments From dmitry at butskoy.name  2005-11-14 10:32 EST -------
> ping -f Matthias || ping -b Somebody  :)
I always knew, that "ping -f" is very effective!  :)

> Why to you force -Wall -fno-strict-aliasing? Do things break without?
These things are present in the original php package for Fedora Core. I don't
know explicitly why, but IMHO I should repeat them too to avoid possibly unknown
issues.

> Why do you export EXTENSION_DIR for the build? Is it really needed?
Yes, it is unneeded.

> Isn't --enable-shared --disable-static the default after phpize?
Yep, remove extra args.

New SRPM & SPEC:

PHP5 & FC4/devel:
http://dmitry.butskoy.name/php-extras/php-extras-5.0.4-1.src.rpm
http://dmitry.butskoy.name/php-extras/php-extras.spec.fc4

PHP4 & FC3:
http://dmitry.butskoy.name/php-extras/php-extras-4.3.11-1.src.rpm
http://dmitry.butskoy.name/php-extras/php-extras.spec.fc3


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.