[Bug 173459] Review Request: initng

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459





------- Additional Comments From gauret at free.fr  2005-11-17 04:40 EST -------
Needs work:
* BuildRequires: fedora-release should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* The package should contain the text of the license
  (wiki: PackageReviewGuidelines)
* Missing ldconfig in %post and %postun
* The doc in installed in /usr/share/doc/initng-0.4.0/initng. The last dir is
superfluous
* Own /etc/initng and /lib/initng
* Typo for -disable-rpath. It's --disable-rpath with two dashes.
* Don't echo anything in %post
* /lib should be replaced by %{_lib} (which is different on 64bit systems)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.