[Bug 173459] Review Request: initng

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459





------- Additional Comments From daner964 at student.liu.se  2005-11-17 04:54 EST -------
(In reply to comment #5)
>  - where can I find Patch0 ?

At the hd of my home computer ;-) I'll put a srpm up here as soon as I get a
chance...

>  - The BuildRoot is not the preferred one 
>    (http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot)
>  - 'CFLAGS="$RPM_OPT_FLAGS"' after 'make' is not necessary, this variable is
> exported in the shell
>  - replace all "/etc" by "%{_sysconfdir}"
>  - replace all "/usr/share" by "%{_datadir}"
>  - since you use "grubby" in %post, you have to add "Requires(post): mkinitrd"

Ok, I'll fix all this.

>  - never echo anything in %post (or other scriptlets)

Ok. Is there any other good way of pointing the users attention to stuff like this?

>  - you may want to run the scriptlet only on fresh install, not on upgrade. Look
> at the beginning of http://fedoraproject.org/wiki/ScriptletSnippets for how to
> do that.
>  - replace '/usr/share/doc/initng-%{version}/*' in %files by
>    '%doc %{_datadir}/doc/initng-%{version}' (%doc because it is documentation,
> and remove the /* at the end to own the initng-%{version} directory

Ok, I'll look at this too. Thanks for the feedback!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.