[Bug 166555] Review Request: orange - Squeeze out installable Microsoft cabinet files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: orange - Squeeze out installable Microsoft cabinet files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166555





------- Additional Comments From Christian.Iseli at licr.org  2005-11-18 10:08 EST -------
Good:
- rpmlint is ok
- name ok
- spec name ok
- packaging guidelines met
- license ok
- license matches actual license in package
- license file in %doc
- spec file in American English and legible
- source ok (CVS)
- builds, installs, runs, and uninstalls cleanly
- BuildRequires ok
- no locale to worry about
- shared libs ok
- no relocation to worry about
- no duplicated files
- files perms ok
- clean section ok
- macro useage ok
- package contains code
- no large doc
- %doc is only doc
- builds in mock

Nit:
I'm not completely sure if there is a definitive policy regarding packages
built from CVS snapshots, but looking around I think the spec file would be
better with the small attached patch applied.

Problem:
It looks like the magic code to detect executable files is not quite up to
snuff.  It seems better with the attached patch.

I'll approve it, if you agree with the patch.

Cheers,
                                        Christian

--- orange.spec.orig    2005-11-18 10:16:13.000000000 +0100
+++ orange.spec 2005-11-18 15:58:15.000000000 +0100
@@ -1,12 +1,15 @@
 Name:           orange
-Version:        0.3cvs
-Release:        0
+Version:        0.3
+Release:        0.cvs20051118%{?dist}
 Summary:        Squeeze out installable Microsoft cabinet files

 Group:          Applications/Communications
 License:        MIT
 URL:            http://synce.sourceforge.net/
 Source0:        orange-CVS-20051118.tar.gz
+# Obtained through:
+# cvs -z3 -d:pserver:anonymous at cvs.sourceforge.net:/cvsroot/synce co -P orange
+Patch0:         orange-chris.patch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 BuildRequires:  synce-devel
@@ -32,6 +35,7 @@ The %{name}-devel package contains the f

 %prep
 %setup -q -n orange
+%patch0 -p1 -b .chris

 %build
 ./bootstrap
@@ -67,6 +71,9 @@ rm -rf $RPM_BUILD_ROOT
 %{_includedir}/liborange.h

 %changelog
+* Fri Nov 18 2005 Christian Iseli <Christian.Iseli[AT]licr.org> 0.3-0
+- grab latest from CVS to use libgsf instead of obsolete libole2
+
 * Tue Sep 27 2005 Andreas Bierfert <andreas.bierfert[AT]lowlatency.de>
 - include patch for new libole2

--- orange/lib/squeeze.c.chris  2005-11-18 15:56:56.000000000 +0100
+++ orange/lib/squeeze.c        2005-11-18 15:56:16.000000000 +0100
@@ -226,7 +226,7 @@
       synce_trace("Found MSI format.");
   }
 #endif
-  else if (strstr(description, "MS-DOS executable (EXE), OS/2 or MS Windows"))
+  else if (strstr(description, " executable "))
   {
     success = squeeze_exe(filename, output_directory);
   }

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.