[Bug 173766] Review Request: taarich - tell the Hebrew (Jewish) date

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 21 14:09:41 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: taarich - tell the Hebrew (Jewish) date


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173766


mpeters at mac.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From mpeters at mac.com  2005-11-21 09:09 EST -------
(In reply to comment #5)
> (in reply to comment 4)
> Yep, that's my bad. I mistakenly understood that Michael A. Peters 
> wanted that the upstream compilation flags would be maintained.
> Will be fixed during next take.

With that change - Approved


Good:

+ (from reviewer MUST section)
* rpmlint output clean:
[mpeters at utility result]$ ls
build.log       taarich-1.20051120-2.fc4.i386.rpm
mockconfig.log  taarich-1.20051120-2.fc4.src.rpm
root.log        taarich-debuginfo-1.20051120-2.fc4.i386.rpm
[mpeters at utility result]$ rpmlint *.rpm
[mpeters at utility result]$

* Package named according to guidelines
- no upstream tarball name, named according to primary binary
* Spec file name matches binary package name
* Package meets packaging guidelines
* OSI Approved license (MIT) - matches source
* License in %doc
* Spec file written in American English
- Hebrew portions obviously appropriate, and english exists
* Spec file legible
* Sources match upstream
- I mirrored upstream ftp directory to verify md5sum of files
--  lftp -e 'mirror -e' ftp://ftp.math.technion.ac.il/calendar/gauss/
* Package succesfully compiles on i386 FC4
* No un-necessary BuildRequires, builds in mock
* No lang files (no need for %find_lang)
* No shared libraries (no need for ldconfig)
* Proper use of macros for paths
* No duplicate files
* Proper %files section - appropriate permissions/ownership
* Proper %clean
* Consistent use of macros
* Package contains code
* No need for separate doc package
* No need for devel package
* No .la files
* No need for desktop file
+ (from reviewer SHOULD section)
* Builds in mock
* Hebrew description
* Package works
[mpeters at utility result]$ taarich
19 Heshvan 5766
[mpeters at utility result]$ 

-=-
Needs:
There should be a Hebrew summary line since there is a Hebrew description.
This is not a blocker, I'm approving. But adding

Summary(he):  Something in Hebrew

under

Summary: Tells the Hebrew date, Torah readings, and generates calendars

would be advised.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list