[Bug 173897] Review Request: fonts-hebrew-fancy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-hebrew-fancy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173897


mpeters at mac.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From mpeters at mac.com  2005-11-22 16:46 EST -------
Reviewed per http://fedoraproject.org/wiki/PackageReviewGuidelines

Good:
* rpmlint clean
* Package name appropriate
- upstream distributes as a series of tarballs, but the source of these
- fonts are grouped together as fancy
- These fonts are from the same project as the Core package fonts-hebrew
* Spec file name matches src.rpm name
* Package meets packaging guidelines
* Specified License (GPL) matches project page and license provided with source
* License in %doc
* Spec file written in American English, Legible
* Sources match upstream md5sum
* spec file works
* No BuildRequires (thus none from exceptions or redundant)
* No locale files
* no shared libraries
* No use of Prefix:
* No duplicates
* Appropriate permissions
* Proper %clean
* consistent use of macros
* contains permisable content
* No need for separate docs package
* files in %doc not necessary for runtime
* No devel/library/etc to worry about
* Contains summary/description for Hebrew
* Sane scriptlets
* Works in FC4 and FC5

Approved

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.