[Bug 165964] Review Request: intuitively. Automatic IP detection utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: intuitively. Automatic IP detection utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165964





------- Additional Comments From pertusus at free.fr  2005-11-27 16:04 EST -------
(In reply to comment #7)

The new srpm should appear shortly at
http://www.environnement.ens.fr/perso/dumas/fc-srpms/intuitively-0.7-5.src.rpm

> Remarks & nitpicks:
> 
> - use '-q' for %setup

done

> - instead of the patch (patch0), just specify "sysconfdir=..." for "make install"

it won't work because @sysconfdir@ is also used in the code.

> - instead of patch1, just use "sed -i 's/.../..../' filename" at prep stage

done

> - there is a garbage in man pages, because instead of "docbook2man file.sgml" a
> wrong "docbook2man file.sgml > file.NUM" is used. Therefore manuals should be
> properly re-created in the end of %build stage.

done

> - IMO it is better to use %{name} and wildcards for %files

I used %{name}, but only in the %files section, I think it is less readable with
%{name} everywhere. I avoided wildcards (except for manpages), because I think
that with the files explicitely specified, it is easier to see that something
sneaked in.

> - Is it useful to include intuitively.conf.dist into the docs? It seems to be
> the same as /etc/intuitively/intuitively.conf ...

Yep it is the same but I think it is better to keep it because the user should
rewrite the /etc/intuitively/intuitively.conf.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.