[Bug 174063] Review Request: cssed - css editor and validator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cssed - css editor and validator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174063


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |gauret at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2005-11-27 17:50 EST -------
Needs work:
* Specfile should be in the format %{name}.spec
  (wiki: PackageReviewGuidelines)
* Spec file :

Line 1:        dont use define prefix, it is already setup for you (as _prefix)
if really needed.
Line s 2-3:    don't define version and release on top of the spec file. Setting
the tag automatically sets the macro.
Line 12:       use http://dl.sourceforge.net/cssed/cssed-%{version}.tar.gz as
the Source tag, to be able to download and check the source directly
Lines 15 & 26: Don't use buildarch i386 (what about x86_64 and ppc ?). Don't use
buildarch: noarch for the -devel rpm also
Line 27:       -devel package should have "Requires: %{name}-%{version}"
Line 34:       minor : cssed-%{version} is already the default dir name, so you
only need "%setup -q", no need for the -n option
Line 37:       export CFLAGS is useless, it will be done by %configure
Line 38:       --prefix and --mandir are already defined by %configure
Line 39:       missing SMP flags. If it doesn't build with it, please add a
comment (wiki: PackagingGuidelines#parallelmake)
Line 42:       the check is useless and misleading, just use rm -rf %{buildroot}
Line 46:       why remove the man file ?
Lines 47-67:   why remove the desktop file and recreate it afterwards ? The
removal is useless: the buildroot has been cleaned at the beginning of %install
Line 60:       you don't need to install the desktop file in the buildroot
before calling desktop-file-install, it will take care of that.
Line 66:       you need to add category X-Fedora in the desktop file (wiki:
PackagingGuidelines#desktop)
Line 70:       don't call make install twice
Lines 71-73:   Just remove this dir since you add the doc with a %doc tag in the
%files list (it isn't there if you remove the additional make install anyway)
Lines 74-78:   this directory should be moved in %{_includedir}/cssed, where
include files are
Line 81:       for %clean, same thing as for %install. Just stick to rm -rf
%{buildroot}
Lines 87-119:  just use %{_datadir}/cssed. It's recursive.
Lines 121-126: use the %find_lang macro to list the translations (wiki:
PackageReviewGuidelines).
Lines 132-138: the include files should be in %_includedir/cssed
Line 139:      you don't need the docs in the -devel package. They are available
in the main package


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.