[Bug 168690] Review Request: pyBackPack (GTK+ Python backup tool)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyBackPack (GTK+ Python backup tool)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168690


mpeters at mac.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From mpeters at mac.com  2005-09-30 20:52 EST -------
* rpmlint clean on src.rpm and resulting noarch rpm
* package name appropriate
* acceptable license
* Spec file clean and easy to understand
* consistant use of macros
* package owns directory and all files it installs
* -- uninstalls cleany after use
* desktop file clean, matches spec
* md5sum matches upstream
* file list sane, file permissions sane
* proper use of macros
* proper use of ghost

* Builds clean in mock, tested on PPC with removable media, succesfully backed
up files, succesfully backed up files after modification, succesfully restored
files after backup.

Only thing I would suggest changing (non blocking) -

1) change
Source: http://stuff

to

Source0: http://stuff

2) Put an empty line between %build and %install sections (for readability)

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.