[Bug 168070] Review request: perl-Mail-GnuPG - Process email with GPG

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 5 18:10:56 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-Mail-GnuPG - Process email with GPG


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168070


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |tcallawa at redhat.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2005-10-05 14:10 EST -------
Warning: prerequisite MIME::Entity 0 not found.
Warning: prerequisite MIME::Parser 0 not found.
Warning: prerequisite Mail::Address 0 not found.

These come from perl-MailTools and perl-Mime-tools. You can resolve this by adding:

BuildRequires: perl(MIME::Entity), perl(MIME::Parser), perl(Mail::Address)

Review (with above change made):
Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL or Artistic) OK, links to license text in README, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED (with BR change)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list