[Bug 169735] Review Request: tetex-fontools - Tools to simplify using fonts.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tetex-fontools - Tools to simplify using fonts.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169735


sarantis at cnl.di.uoa.gr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |sarantis at cnl.di.uoa.gr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From sarantis at cnl.di.uoa.gr  2005-10-07 07:28 EST -------
Good:

- rpmlint checks return nothing.
- package meets naming guidelines
- package meets packaging guidelines
- license ( ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package noarch
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

TODO:
- tetex-fonts is both Required directly by package name and indirectly through
the texhash dependancy.  I think one of them is enough.
- In the %files section, replace the %{_texmf}/doc/ with the spec-defined
%{texpkgdoc}.  The former is wrong, since it also includes the latex directory.
- (minor) The date in the downloaded fontools.zip file is different than the one
I get.  I am not sure if this is a ctan problem or whether it can be corrected
(e.g. using wget -N).

With these remarks taken care of, the package is approved.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.