[Bug 168213] Review request: perl-Test-Inline - Test::Inline Perl module
bugzilla at redhat.com
bugzilla at redhat.com
Fri Oct 7 13:22:30 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review request: perl-Test-Inline - Test::Inline Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168213
paul at city-fan.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |paul at city-fan.org
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From paul at city-fan.org 2005-10-07 09:22 EST -------
I'm back, after taking it easy for a couple of weeks due to the birth of my
first child...
Review:
- rpmlint nearly clean, see below
- package and spec file naming OK
- package meets guidelines
- license is same as perl, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock on FC4 (i386)
- BR's OK; long list of versioned dependencies matches Makefile.PL
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no .desktop file needed
- no scriptlets
Nitpick:
- a couple of typos/comment changes:
"# 2.100 - 2.102 ship with executable Changes" still applies to 2.103
changelog entry "Add filter-requires to filter bogus perl(strict)" should
refer to perl(script), not perl(strict)
- add BR: perl(Test::Pod) for extra test coverage
Notes:
= rpmlint output:
W: perl-Test-Inline strange-permission perl-Test-Inline-filter-requires.sh 0755
script needs to be executable in SRPM or it won't work, so this is OK.
- the filter-requires script is used to filter out the bogus perl(script)
dependency originating from Test/Inline/Content.pm
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list