[Bug 166414] Review Request: grace (Numerical Data Processing and Visualization Tool)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: grace (Numerical Data Processing and Visualization Tool)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166414





------- Additional Comments From ed at eh3.com  2005-10-10 13:30 EST -------
Hi folks,

Heres a quick-ish review:

needswork:
 - rpmlint complains about soft links:

   W: grace dangling-symlink /usr/share/grace/bin /usr/bin
   W: grace symlink-should-be-relative /usr/share/grace/bin /usr/bin
   ...
   W: grace-devel dangling-symlink /usr/share/grace/include 
      /usr/include
   W: grace-devel symlink-should-be-relative /usr/share/grace/include
      /usr/include

   which could be converted to relative links which would remove half
   of the warnings

OK:
 - source matches upstream
 - naming and spec look good
 - license looks OK and is in %doc
 - builds in mock on FC4
 - runs without segfaulting
 - code not content OK
 - desktop-file-install looks OK

and I don't see any blockers.  Since Patrice seems to have done most 
of the actual review work I think he deserves to be the reviewer!  We've
discussed on the extras mailing list how to get the bugzilla permissions
for that so he should be able to do it.

And if Patrice can't be the formal reviewer then someone please ping me 
this coming weekend and I'll approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.