[Bug 170506] Review Request: grepmail

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: grepmail


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170506





------- Additional Comments From rc040203 at freenet.de  2005-10-13 10:45 EST -------
(In reply to comment #5)
> (In reply to comment #4)
> > Just a comment:
> > %{_bindir}/find ...
> > 
> > is pretty much free of sense. %_bindir is a user input parameter to rpmbuild,
> > not an rpm-internal constant (%__chmod etc. are rpmbuild internal constants).
> 
> Is this distinction described somewhere?
Rhethorical question: Is there any official documentation on rpm?

Not that I am aware about. Only that "%_bindir" etc. are documented as
"configure macros" in /usr/lib/rpm/macros, which means they are meant to be
configuration input to be passed to a package, and do not denote a system
feature (such as presence of /usr/bin/find, or %{__chmod}).

Also, it's common practice for many years that users override the "autoconf"
macros for various purposes. 

%_bindir/find requires you to use "BuildRequires: %_bindir/find" which
unnecessarily prohibits users wanting to rebuild your rpm with a different _bindir.

> Both %_bindir and %__chmod are defined in /usr/lib/rpm/macros and can be
> redefined in the same way on the command-line.
True, but note that these %__XXX macros use hardcoded directories, such as
/usr/bin and do not use %_bindir. 

IMO, this is yet another strong indication for your usage to be incorrect.

However probably only Jeff would be able to give a confirmative answer.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.