[Bug 167885] Review Request: libpolyxmass - Polymer chemistry-related functionalities

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 20 22:15:46 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libpolyxmass - Polymer chemistry-related functionalities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167885


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |jpmahowald at gmail.com




------- Additional Comments From jpmahowald at gmail.com  2005-10-20 18:15 EST -------
The URL line is longer, but oh well.

- license good (GPL), text in %doc
- name follows guidelines
- spec file easily read
- builds on FC4 i386
- rpmlint only warns about changelog, can ignore
- used %find_lang macro
- sources match upstream
- no missing/unneeded BuildRequires
- consistent macro usage
- %post and %postun ldconfig
- devel package only installs a symlink, no need for ldconfig
- %clean good
- *.la removed

However,
- no %defattr for devel package

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list