[Bug 167889] Review Request: polyxmass-data - Contains configuration files describing polymer chemistry

bugzilla at redhat.com bugzilla at redhat.com
Sun Oct 23 13:13:40 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: polyxmass-data - Contains configuration files describing polymer chemistry


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167889





------- Additional Comments From paul at city-fan.org  2005-10-23 09:13 EST -------
(In reply to comment #1)
> This data is necessary for polyxmass to be useful, so it is acceptable data
> 
> - package meets naming guidelines
> - package meets packaging guidelines
> - license (GPL) OK, text in %doc
> - spec file legible
> - source matches upstream
> - package compiles on FC4 i386
> - no BR
> - no locales
> - not relocatable
> - no duplicate files
> - permissions ok
> - %clean ok
> - macro use consistent
> - code, not content
> - no need for -docs
> - nothing in %doc affects runtime
> - no need for .desktop file 
> 
> needs work:
> - does not appear to own or require /usr/share/polyxmass
> - rpmlint:
> W: polyxmass-data non-conffile-in-etc
> /etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-cat
> W: polyxmass-data non-conffile-in-etc
> /etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-atom-defs-dic
> 
> and a while lot of zero length .ogg files. Are the oggs necessary? The conffile
> can probably be ignored, it's really a config file.

If the files in /etc/polyxmass really are config files, perhaps then they should
be marked as such?

%config %{_sysconfdir}/polyxmass/polchem-defs*
or
%config(noreplace) %{_sysconfdir}/polyxmass/polchem-defs/*


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list