[Bug 171565] Review Request: drgeo

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: drgeo


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171565





------- Additional Comments From eric.tanguy at univ-nantes.fr  2005-10-23 13:52 EST -------
(In reply to comment #1)
> Spec File:
> * Url: http://www.ofset.org/drgeo

Done

> * %description: "is a interactive" -> "is an interactive"
>   "figure" -> "figures"

Done

> * BuildRequires: why include gnome-libs-devel, which is for gnome 1.4?
> * "%configure" suffices no need for "--prefix"

Done

> * I think "rm" and "make" can (should?) be used instead of the macros

Done

> * A litte post-processing of the .desktop file in %install:
>   desktop-file-install \
>     --delete-original \
>     --vendor=fedora \
>     --add-category X-Fedora \
>     --dir %{buildroot}%{_datadir}/applications \
>     %{buildroot}%{_datadir}/applications/drgeo.desktop
>   Of course, BuildRequires: desktop-file-utils

Done

> * .desktop file sets icon to gnome-drgenius.png which does not exist.
>   Suggest copying drgeo.png and setting "Icon: drgeo.png"
>   (why is this commented out?)

Done

> * Since there is no html documentation, consider patching the source
>   to remove the "Contents" menu and button, and notifying upstream
>   to correct this.

Ok I notified it upstream but i know only few about programming and i don't how
to patch this ...

> * The texmacs files should go to %{_datadir}/TeXmacs/plugins/drgeo

Done

> * update changelog

Done

> 
> 

Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo.spec
SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-1.1.0-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.