[Bug 168185] Review Request: z88dk - Z80 cross compiler

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 26 15:47:34 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: z88dk - Z80 cross compiler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168185


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-10-26 11:47 EST -------
Review:

- rpmlint issues only warnings (see below)
- package and spec naming OK
- package meets guidelines
- license is Artistic, matches spec, text included
- spec file written in English and is legible
- source matches upstream
- no explicit BR's
- package builds ok in mock for FC4 (i386)
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- there are a few duplicate files within the examples (same header file for
  different target platforms for example); since they add up to less than 100k
  bytes, I'm inclined to ignore this but you might consider replacing them
  with symlinks
- %clean section present and correct
- macro usage is consistent
- code, not content
- it's debatable whether the documentation is "large" or not; I'd be inclined
  to split off a "-examples" subpackage but I think this is a borderline case
  and I'll leave it up to you
- docs don't affect runtime
- no desktop entry needed
- no scriptlets
- tested a couple of the spectrum examples in the fuse emulator and they
  worked

Notes:

- rpmlint output:
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz700/ozserial.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/stdlib.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/MemoDB.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/float.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz700/oztime.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/rex.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/Database.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/register.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/zxvgs.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/syscall.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/spectrum.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/socket.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/z88.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/help0.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/zsockerrs.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/help6.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/debug.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/help4.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/zsfiles.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/TextInfDB.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/gray.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/application.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/resolv.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/ti.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/help2.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/tftp.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/device.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/math.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/stdio.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/sys/types.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/command5.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/resolver.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/command3.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/cpm.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/command1.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/command7.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/dor.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/z88stdio.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/string.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/iso646.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/time.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/StatusDB.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/strings.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/tcpsock.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rs232.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz700/ozgfx.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/malloc.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/setjmp.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/library.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz700/ozmisc.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/graphics.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz700/ozscreen.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz700/ozint.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz700/ozfont.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/stdio.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/conio.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/zxinterface1.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/help1.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/help7.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/gui.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/sys/stat.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz700/ozinput.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/inet.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/games.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/help5.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/fcntl.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/netstats.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/package.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/struct.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/telnet.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/command4.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/message.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/ctype.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/misc.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/syscallEx.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/command2.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/help3.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/zxlowgfx.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/command0.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz/command6.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/CalendarDB.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/sound.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/lib3d.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/limits.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/rex/TaskDB.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/stdarg.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/oz700/scaldate.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/assert.h
W: z88dk devel-file-in-non-devel-package /usr/share/z88dk/include/net/hton.h
  These warnings can IMHO be ignored because they are all warnings about header
  files that are directly used by the compiler itself, much like the header
  files included in the regular gcc package

- the package does not build on RHEL3 x86_64; if there are similar issues for
  Fedora then a bug will need to be raised for each excluded architecture

- Adding a README.fuse-emulator describing how to run some of the examples in
  the emulator would be useful

Approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list