[Bug 167258] Review Request: up-imapproxy: University of Pennsylvania IMAP Proxy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: up-imapproxy: University of Pennsylvania IMAP Proxy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167258


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul at city-fan.org




------- Additional Comments From paul at city-fan.org  2005-09-01 10:49 EST -------
(In reply to comment #1)
> Before this gets reviewed, I want to ask about rpmlint output:
> 
> W: up-imapproxy incoherent-version-in-changelog up-imapproxy-1.2.3-3 1.2.3-3
> 
> I don't understand this one.  This changelog is just like the last package I
> submitted, which was fine.  Is it because of the additional '-' in the package
name?

Just use the epoch/version/release numbers, don't include the package name at all.

> E: up-imapproxy init-script-without-chkconfig-postin /etc/rc.d/init.d/imapproxy
> 
> Um, I thought it was a bad idea to enable a service just because it is being
> installed.

It wants you to do a "chkconfig -add" in %post; this doesn't necessarily enable
the service - if you have "-" for the default runlevels then the service will be
disabled by default.

> E: up-imapproxy no-status-entry /etc/rc.d/init.d/imapproxy
> 
> I didn't write the init script.  It is packaged in the source.  I could write
> another one if it is required.
> 
> W: up-imapproxy no-reload-entry /etc/rc.d/init.d/imapproxy
> 
> See above comment.

The initscript in the source is rather old-fashioned. I'll attach a new one to
this report shortly.

> W: up-imapproxy service-default-enabled /etc/rc.d/init.d/imapproxy
> 
> I don't know what this means.

The chkconfig line in the initscript specifies default runlevels of 2345, so a
"chkconfig -add imapproxy" will enable the service in those runlevels.

> E: up-imapproxy subsys-not-used /etc/rc.d/init.d/imapproxy
> 
> I think I might know what this means, but I could be wrong.  However, again, I
> didn't write the init script.

The initscript doesn't track state by creating a /var/lock/subsys/in.imapproxyd
file when running.

> W: up-imapproxy incoherent-init-script-name imapproxy
> 
> Is this because the init script is "imapproxy" and the package is
> "up-imapproxy?"  This seems rather trivial, especially since "up" just means
> "University of Pennsylvania."  The source tarball is "up-imapproxy," the daemon
> is "in.imapproxy," and the service is called "imapproxy."  I don't think this is
> a significant issue.

Neither do I. You can't completely get rid of the incoherency because the
package is called up-imapproxy and the actual daemon is called in.imapproxyd, so
I'd leave this as it is.

More suggestions coming soon...



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.