[Bug 166414] Review Request: grace (Numerical Data Processing and Visualization Tool)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: grace (Numerical Data Processing and Visualization Tool)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166414


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2005-09-03 14:17 EST -------
Some remarks/suggestions

* convcal.c is not an example file but a source file so it seems better not to 
  package it
* the library is LGPL and not GPL
* Xbae has a BSD licence that should be included
* man pages are duplicated in doc directory and at their normal place
* doc/ and examples/ are better in %doc than in /usr/share/grace
* the path to fdf2fit in gracerc seems wrong to me, it should be in bin/ not in
auxiliary/
* I think it is better to add the netcdf directory --with-extra-ldpath than to
hardcode the netcdf library, such that if the netcdf library is turned into a
dynamic library things will still be right.

I attach a diff for the spec file implementing thoses suggestions, and a patch.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.