rpms/grhino/devel grhino-Makefile-in.patch, NONE, 1.1 grhino.desktop, NONE, 1.1 grhino.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2

[Tom 'spot' Callaway]

On Sun, 2005-09-04 at 18:13 -0500, Michel Alexandre Salim wrote:
> On Sun, 2005-09-04 at 16:08 -0500, Tom 'spot' Callaway wrote:
> > On Sun, 2005-09-04 at 20:42 +0200, Michael Schwendt wrote:
> > > On Sun, 04 Sep 2005 12:27:07 -0500, Michel Alexandre Salim wrote:
> > > 
> > > > While on the topic, has anything major changed in glibc for x86_64
> > > > between FC3 and FC4? grhino builds fine on FC3/x86_64 but not FC4 and
> > > > above (log attached); on i386 it builds fine across all versions.
> > > 
> > > This in the build log is suspicous:
> > > 
> > > checking for GNU gettext in libintl... no
> > 
> > I almost certainly think that is the case.
> > 
> > This occurs because the configure test for gettext fails because it
> > casts a 64 bit pointer to a 32 bit (int), which causes a
> > 'cast from pointer to integer loses precision' error.
> > 
> > I've attached a patch that might resolve it, not tested.
> > 
> The patch actually causes gettext detection to fail on both 32-bit i386
> and 64-bit x86_64. I forwarded it to the upstream developer for
> reference; in the meantime I'm just overriding configure's test for
> gettext, hope that's allowed?

Sounds good to me. Much better than a patch which doesn't work. :)

~spot
-- 
Tom "spot" Callaway: Red Hat Senior Sales Engineer || GPG ID: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!