[Bug 166185] Review Request: perl-Class-DBI-AbstractSearch : Abstract Class::DBI's SQL with SQL::Abstract
bugzilla at redhat.com
bugzilla at redhat.com
Tue Sep 6 11:35:54 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-DBI-AbstractSearch : Abstract Class::DBI's SQL with SQL::Abstract
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166185
paul at city-fan.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |paul at city-fan.org
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From paul at city-fan.org 2005-09-06 07:35 EST -------
Review:
- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds ok in FC4 and in mock for development (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
Needswork:
- remove redundant BR: perl
- include license text
Nitpick:
- honor %{?_smp_mflags}
- add BR: perl(DBD::SQLite) for better test coverage
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list