[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 167544] Review Request: netgo : Networking profile manager



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: netgo : Networking profile manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167544


Christian Iseli licr org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From Christian Iseli licr org  2005-09-16 18:56 EST -------
Good:
- rpmlint is pretty happy:
W: netgo no-dependency-on usermode-consoleonly
- name ok
- spec name ok
- packaging guidelines met
- license ok
- license matches actual license in package
- license file in %doc
- spec file in American English and legible
- source matches upstream
- builds, installs, runs, and uninstalls cleanly
- BuildRequires ok
- no locale to worry about
- no shared libs to worry about
- no relocation to worry about
- no duplicated files
- files perms ok
- clean section ok
- macro useage ok
- package contains code
- no large doc
- %doc is only doc
- desktop file present
- builds in mock

Bad:
- owns all dirs
Patch below.

Minor nit:
I'd add the README file to %doc...

Approved.

Cheers,
                                        Christian


--- netgo.spec.orig     2005-09-17 00:51:00.000000000 +0200
+++ netgo.spec  2005-09-17 00:52:57.000000000 +0200
@@ -1,6 +1,6 @@
 Name:          netgo
 Version:       0.5
-Release:       2%{?dist}
+Release:       3%{?dist}
 License:       GPL
 Group:         Applications/System
 Summary:       Networking profile manager
@@ -73,10 +73,13 @@ rm -rf $RPM_BUILD_ROOT
 %config(noreplace) %{_sysconfdir}/security/console.apps/netgo
 %{_datadir}/applications/fedora-netgo.desktop
 %{_datadir}/pixmaps/netgo.png
-%{_datadir}/netgo/icons/globe_32x32.png
+%{_datadir}/netgo
 %{_sbindir}/netgo

 %changelog
+* Sat Sep 17 2005 Christian Iseli <Christian Iseli licr org> 0.5-3
+- fix unowned dir
+
 * Fri Sep 16 2005 Tom "spot" Callaway <tcallawa redhat com> 0.5-2
 - move netgo-bin to %%{_sbindir}/netgo



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]