[Bug 169082] Review Request: physfs: Library to provide abstract access to various archives

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: physfs: Library to provide abstract access to various archives


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169082


adrian at lisas.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |adrian at lisas.de
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From adrian at lisas.de  2005-09-23 04:52 EST -------
* rpmlint is happy
* builds in mock
* clean installation and removal
* source matches upstream
* spec looks good
* correct usage of -devel
* sane scripts
* test binary works

APPROVED

If you BR doxygen, you could also generate the documentation and put it into the
 -devel package.

The INSTALL file could be removed.

I also think that it should be no problem that the header file from the -devel
package is directly in /usr/include as it is only one file and the name doesn't
sound too generic. If physfs will start to provide more include files in the
future a separate include directory might make more sense.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.