[Bug 166008] Review Request: uw-imap-2004e-1: UW Server daemons for IMAP and POP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: uw-imap-2004e-1: UW Server daemons for IMAP and POP


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166008


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |gauret at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2005-09-26 11:21 EST -------
OK, I did not check actual file conflict.

Needs work:
* source is not available anymore, please update to 2004g
* Specfile should be in the format %{name}.spec
* Missing SMP flags ( make %{?_smp_mflags} ). If it doesn't build with it,
  please leave a comment
* Duplicate BuildRequires: krb5-devel (required by openssl-devel)
* Let's-Make-Rpmlint-Happy : Summary ends with a dot
* %postun scriptlet for libc-client2004e contains your comment for the next 
scriptlet, and the interpreter is ldconfig, not bash.
* The package should contain the text of the license (in the "CPYRIGHT" file)
* missing dependancy on service (package initscripts) for %post and %postun
* hardcoded /var and /usr in patch0
* hardcoded /etc in the specfile, should be replaced by %{_sysconfdir}. Same
thing for /usr (in %build)
* Prereq is used. It should be Requires(post) and Requires(postun) 
  (Requires(postun) implies Prereq anyway).
* hardcoded /etc in %files, please replace with %{_sysconfdir}

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.