Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: shorewall
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169378
gauret at free.fr changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |gauret at free.fr
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From gauret at free.fr 2005-09-27 18:44 EST -------
Needs work:
* the conf files in /etc/shorewall should be set with flag noreplace
* /usr/share/shorewall dir should be 755 and the files in it should be readable,
since they are not conf files there is no point in making them 600.
* the service is enabled by default, please run a substitution on
/etc/init.d/shorewall to change the chkconfig line
* Requirements: missing dependancy on chkconfig in %post and %preun
* Scriptlets: missing "service" command in %preun and %postun
(wiki: ScriptletSnippets)
* In the files list, /sbin should be replaced with %{_sbindir}
Minor:
* remove empty %build section
* %{_prefix}/share should be replaced with %{_datadir}
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.